[Pianod] Build 111 - user persistence changes

[Peter Li]

Does it need to be all or nothing?

I can handle writing a libpiano/Makefile and then calling that from 
pianod/Makefile.  Trying to move a dynamic libpiano out into the system 
doesn't make that much sense to me though, so I would just go with 
building and linking libpiano statically from within the build.  In that 
case it's not clear to me that its any different from just building 
libpiano's objects with more careful separation, but if we're going to 
make a separate Makefile and try to extricate things properly then we 
might as well build a static archive.

I can understand wanting to fix everything while we're at it, but if you 
prefer I think this is something that can be fixed surgically and we can 
get to larger reworkings when it's more opportune.  I guess one other 
option is that we could set up libpiano to build with some more fancy 
system as a trial run for a larger reworking.  But it would definitely 
feel like overkill :).

P



On 02/12/2013 05:37 PM, Perette Barella wrote:
> So the Right Way to do this would be to have Makefiles for each of the libraries that compiles them, produces library suitable for linking, and delivers the library and include files somewhere.  Subsequent components then include/link against that delivery location, rather than the library's source.  Done this way, libpiano's private "crypt.h" doesn't conflict with the public <crypt.h>.
>
> I'll mull over how to go forward.  The right way is to fix the Makefiles once and for all, but that means a lot more work and it's unfortunately in an area we don't seem to have expertise at the moment.  So you are correct in that it is not so easy to extricate things, but it is possible and since we makefiles are already suspect it's worth mulling over.
>
>
>
>
>
> On 2013年02月12日, at 20:01, Peter Li wrote:
>
>> On 02/12/2013 04:54 PM, Perette Barella wrote:
>>> This is really a fault with the Makefile. We should be compiling the libraries individually and then linking them.
>> Well, I tried rerunning the users.o compilation line with the -I src/libpiano removed; doesn't work since libpiano/piano.h is needed.  So seems like not so easy to extricate things.  I suppose we could drop -I src/libpiano and include "libpiano/piano.h" from pianod instead?
>> _______________________________________________
>> Pianod mailing list
>> Pianod at lists.deviousfish.com
>> http://lists.deviousfish.com/listinfo.cgi/pianod-deviousfish.com
> _______________________________________________
> Pianod mailing list
> Pianod at lists.deviousfish.com
> http://lists.deviousfish.com/listinfo.cgi/pianod-deviousfish.com